You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the serial plan starts we want to make a data collection group with the correct parameters. We can do this by doing something similar to what GridscanISPyBCallback does on activity_gated_start.
Make the serial collection plan emit a start document at the beginning of running
Move DiffractionExperimentWithSample to somewhere common and make one in the plan out of the parameters we have
The start document should have enough info to be able to call populate_data_collection_group by putting the params into something that inherits from DiffractionExperimentWithSample
Move BaseISPyBCallback into the common area
Create a subclass of BaseISPyBCallback that uses these parameters to make a group at start (does it make sense to refactor this into the start of BaseISPyBCallback?)
Acceptance Criteria
On running serial collections a group is created with the expected params
There is a system test that runs this against the dev ispyb database (we already have similar for other plans)
The text was updated successfully, but these errors were encountered:
When the serial plan starts we want to make a data collection group with the correct parameters. We can do this by doing something similar to what
GridscanISPyBCallback
does onactivity_gated_start
.DiffractionExperimentWithSample
to somewhere common and make one in the plan out of the parameters we havepopulate_data_collection_group
by putting the params into something that inherits fromDiffractionExperimentWithSample
BaseISPyBCallback
into the common areaBaseISPyBCallback
that uses these parameters to make a group at start (does it make sense to refactor this into the start ofBaseISPyBCallback
?)Acceptance Criteria
The text was updated successfully, but these errors were encountered: