Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I24 SSX: Create a data collection group on start #576

Open
5 tasks
DominicOram opened this issue Oct 15, 2024 · 1 comment
Open
5 tasks

I24 SSX: Create a data collection group on start #576

DominicOram opened this issue Oct 15, 2024 · 1 comment
Labels
I24 serial Issues relating to ssx on I24

Comments

@DominicOram
Copy link
Contributor

When the serial plan starts we want to make a data collection group with the correct parameters. We can do this by doing something similar to what GridscanISPyBCallback does on activity_gated_start.

  • Make the serial collection plan emit a start document at the beginning of running
  • Move DiffractionExperimentWithSample to somewhere common and make one in the plan out of the parameters we have
  • The start document should have enough info to be able to call populate_data_collection_group by putting the params into something that inherits from DiffractionExperimentWithSample
  • Move BaseISPyBCallback into the common area
  • Create a subclass of BaseISPyBCallback that uses these parameters to make a group at start (does it make sense to refactor this into the start of BaseISPyBCallback?)

Acceptance Criteria

  • On running serial collections a group is created with the expected params
  • There is a system test that runs this against the dev ispyb database (we already have similar for other plans)
@DominicOram DominicOram added the I24 serial Issues relating to ssx on I24 label Oct 15, 2024
@noemifrisina
Copy link
Contributor

Move BaseISPyBCallback into the common area

This will very likely be done as part of #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Development

No branches or pull requests

2 participants