-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to play sounds #3
Comments
Checked the terminal and it seems the vorbis library could not be loaded: |
I had hoped MacOS had better inate support for Ogg Vorbis... |
Didn't work on either. Same result as before on macOS and Windows. On macOS I installed ogg and vorbis via homebrew: user@User-Air ~ % brew install libvorbis and the result I got was the same: On Windows 11 I can't see the console so I don't know the error. I tried copying both dlls to the same folder as the exe and also to System32 with the same result. Note: I am running Windows 11 on Parallels. |
After having spent hours learning more about Python ctypes than I'd hoped, it seems the OggVorbis library loading code of the FSB soundbank library I use for this is a bit wonky :/ |
I just downloaded and installed Thimbleweed Park and get an error when I open the OGG files on macOS. The WAV files work well. The OGG files play well on Windows 11. Note: I have python3 installed and is NOT 32bit. I am running it on a Macbook Air with M1 chip (Apple Silicon). Checking the libraries https://formulae.brew.sh/formula/libvorbis and https://formulae.brew.sh/formula/libogg it seems they are supported by M1. |
After some more searching and trying, the problem may be that Homebrew installs the packages outside the virtual environment created in step 4 of the set-up.
I really really hope this works, but if it doesn't, I'll keep searching for a solution. Please let me know, and thanks a lot for all your help so far! |
Didn't work. With Return to Monkey Island I got the following error: With Thimbleweed Park I got the following: |
I had to fight with a Linux Mint virtual machine for most of the day, but I changed and added some readme steps. And if that doesn't work, maybe the PyOgg library is getting confused by your computer being Apple Silicon. If so, could you navigate to ThimbleMonkey-main/venv/lib/python3.10/site-packages/pyogg, see if there's a subfolder called 'libs' there, and if so, deleting it, and then trying to open a Thimbleweed Park .ogg and Return To Monkey Island soundbank file again? That's more a workaround than a fix, but if it works, it'd at least give an idea of what the cause of this problem even is. |
I got an error with the first command: I tried compiling it without those additional steps ("apt"), but got exactly the same error when trying to play OGG files. I quit the app and deleted the folder "libs" you mentioned and no change, the same errors again. |
Aw shoot, I didn't realise MacOS doesn't have the 'apt' command, sorry. Skip that step then. I've updated the readme again. |
Thanks for the help. I did try, but no luck (check the previous comment). |
Oh sorry, I must've missed your edit. |
Do you mean PyOgg? I did find a similar issue of someone trying to use it to play OPUS files: |
Oh, that's a good hint, thanks! I was searching for PyOgg problems with Ogg and Vorbis, but the issue you linked could be related. |
Happy new year, and thanks again for your support. :) Unfortunately, it didn't work. I even tried compiling it from scratch, but I got the same result as before and the same errors. |
Happy new year to you too! I tried another fix to my PyOgg fork, could you try updating and/or starting from scratch again? |
Sorry, didn't work after starting from scratch (including a new terminal window). BTW, I believe there are two issues:
|
I was so focussed on this MacOS problem that I forgot that to open the soundbanks on Windows, some extra DLLs are needed. I updated the readme. I also spent most of yesterday and today setting up a MacOS VM to see if I could reproduce the error. And... I can't. For me it all works, playing a .ogg even worked before I installed libogg and libvorbis. |
For Windows, you mean libvorbis.dll and libogg.dll? I have those next to the executable and it doesn't work either. on macOs I tried adding that line |
The Windows executable already has those DLLs inside it, so that should already work. Adding the DLLs is only if you're running the Python script directly. It works for me on Windows 10, hopefully Windows 11 doesn't do anything weird... Guess I've got another VM to set up. And for MacOS, adding a line to .zprofile requires restarting the terminal before it takes effect, did you do that too? Because otherwise I'm really running out of ideas... |
I reinstalled homebrew and restarted the laptop afterwards, but still no luck. The .zprofile also looks good:
No really sure what I'm missing. For Windows 11, I should point out that I'm running the Windows 11 ARM version. Not sure if that makes any difference. I never had any issues with other applications. |
I've released a new version with the KTX export error fix that you also helped with. As for the ARM version for Windows, I feel bad having to say it but I can't support that version, because I don't know how that works and I don't have a way to run it, sorry :( |
Ok, I tried something a bit more drastic by re-implementing some code from a library I use. |
Good to hear the Windows ARM version works now! |
Well done!! Now it also works on my macOS for both Thimbleweed Park and Return to Monkey Island. Thanks a lot for being persistent and fixing the issue. 👍 I only encountered a minor problem on macOS where I can't stop a sound while playing the audio (the stop button doesn't do anything). I need to wait for it to stop. |
Oh, good to hear it works on ARM MacOS too now! I didn't expect that, so it's a nice bonus. I had to change something in the soundbank parsing to fix a Windows-only crash, and I made a new release for it, could you perhaps quickly check if the sound parsing still works properly? |
All (macOS and Windows) working now, including the stop button. Also, no more random crashes. |
The stop button breaking and working is stil kind of weird, but I'm VERY glad everything is working now! I get to finally close this issue now, good feeling :) |
I recently downloaded the latest version to try out the music and sounds but none seem to work. When I selected the file and pressed play nothing seems to happen. The length of the sounds remains the same. Same behaviour when compiling it myself on macOS or running it on Windows 11 with the already compiled executable.
The text was updated successfully, but these errors were encountered: