Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support federated tracing #9

Open
kdawgwilk opened this issue Jul 15, 2021 · 2 comments
Open

Support federated tracing #9

kdawgwilk opened this issue Jul 15, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kdawgwilk
Copy link
Collaborator

kdawgwilk commented Jul 15, 2021

Docs on federated tracing https://www.apollographql.com/docs/federation/metrics/

Proto file: https://github.com/apollographql/apollo-server/blob/main/packages/apollo-reporting-protobuf/src/reports.proto

See example tracing library for absinthe https://github.com/sikanhe/apollo-tracing-elixir

Possible design

  1. CreateTrace document phase that creates a stub %Trace{} and stuffs it into blueprint.execution.acc
  2. Middleware that adds a %Trace.Node{} in the resolution.extensions for each field that gets resolved
  3. AccumulateResult document phase that walks the tree building up the trace hierarchy from the %Resolution{} structs
  4. AddExtension document phase that takes the accumulated result and puts it into the blueprint.result.extensions
@kdawgwilk kdawgwilk changed the title Look into supporting federated tracing Support federated tracing Sep 22, 2021
@kdawgwilk kdawgwilk added the enhancement New feature or request label Sep 22, 2021
@kdawgwilk kdawgwilk self-assigned this Sep 25, 2021
@kdawgwilk kdawgwilk added this to the v1.0 milestone Sep 29, 2021
@abdilaziz-ibrahim
Copy link

Any updates here? Curious if theres been any progress/workarounds people have used to get around this issue. Seems like a must for most production use cases doesn't it?

@kdawgwilk
Copy link
Collaborator Author

@abdilaziz-ibrahim we have tracing setup with datadog and open telemetry and are leaning more towards that instead of fleshing this support out

@kzlsakal kzlsakal removed this from the v1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants