Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using this as a dependency, recompiling fails #51

Open
BrainStone opened this issue Apr 24, 2018 · 1 comment
Open

When using this as a dependency, recompiling fails #51

BrainStone opened this issue Apr 24, 2018 · 1 comment
Labels

Comments

@BrainStone
Copy link

When I try to run setupDecompWorkspace with the most recent version of this, it runs fine until it hits recompileMC. Then it errors with Compile failed; see the compiler error output for details.. Running it again with the --info flag yields the following:

Error:

[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\SimpleModelFontRenderer.java:64: error: renderDefaultChar(int,boolean) in SimpleModelFontRenderer cannot override renderDefaultChar(int,boolean) in FontRenderer
[ant:javac]     protected float renderDefaultChar(int pos, boolean italic)
[ant:javac]                     ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\SimpleModelFontRenderer.java:159: error: renderUnicodeChar(char,boolean) in SimpleModelFontRenderer cannot override renderUnicodeChar(char,boolean) in FontRenderer
[ant:javac]     protected abstract float renderUnicodeChar(char c, boolean italic);
[ant:javac]                              ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraftforge\client\model\FancyMissingModel.java:60: error: renderUnicodeChar(char,boolean) in <anonymous net.minecraftforge.client.model.FancyMissingModel$1$1> cannot override renderUnicodeChar(char,boolean) in FontRenderer
[ant:javac]                 protected float renderUnicodeChar(char c, boolean italic)
[ant:javac]                                 ^
[ant:javac]   attempting to assign weaker access privileges; was public

I'm guessing that incompatibility arises because in recent versions of Forge they changed the corresponding methods in their code. I am using Forge 1.12.2 - 14.23.3.2655 btw

Full log: https://gist.github.com/BrainStone/21633afc5add2e2cab7a8b45b6dd62d0
Repo: https://github.com/BrainStone/brainstone

@BrainStone
Copy link
Author

BrainStone commented Apr 24, 2018

This commit introduces the issue! 58e198d

So changing the line public net.minecraft.client.gui.FontRenderer *() to protected net.minecraft.client.gui.FontRenderer *() seems to still compile and would fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants