Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output filtered reads should inherit input file type. #23

Open
cerebis opened this issue Jun 17, 2023 · 1 comment
Open

Output filtered reads should inherit input file type. #23

cerebis opened this issue Jun 17, 2023 · 1 comment

Comments

@cerebis
Copy link

cerebis commented Jun 17, 2023

https://github.com/Dreycey/PhageFilter/blob/963095238b15e163024ea98fc598cc89798961a4/src/main.rs#L301C17-L319

I see around here that PhageFilter is manually writing output as fasta format. It is likely that input reads will be fastq format, where the qualities are definitely relevant and should be maintained in the output. I would love to see the format inherited.

Otherwise, it might be simpler to write only IDs and pass the responsibility to read extraction to another tool, such as samtools.

@Dreycey
Copy link
Owner

Dreycey commented Jun 17, 2023

These are both things that we discussed during development! I think keeping the output the same as the input file makes sense. Also adding this to the backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants