Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Fatal.pm into autodie.pm? [rt.cpan.org #99778] #102

Open
toddr opened this issue Jan 16, 2020 · 3 comments
Open

Copy Fatal.pm into autodie.pm? [rt.cpan.org #99778] #102

toddr opened this issue Jan 16, 2020 · 3 comments

Comments

@toddr
Copy link
Collaborator

toddr commented Jan 16, 2020

Migrated from rt.cpan.org#99778 (status was 'open')

Requestors:

From @karenetheridge on 2014-10-24 17:08:56
:
I've been receiving a bunch of failing cpantesters reports like this:

"Incorrect version of Fatal.pm loaded by autodie..."

http://www.cpantesters.org/cpan/report/09903146-5ad1-11e4-97a5-44010a8c9ca5

I'm wondering whether the time has come to simply copy the code in Fatal.pm into autodie.pm, and add a big deprecation warning into Fatal.pm?

From @toddr on 2020-01-08 07:02:11
:
I don't know the history here but I think this can be closed as complete, right?

From @karenetheridge on 2020-01-08 17:36:18
:

Fatal.pm still has a lot of guts in it, but it's unknown how many things are still
dependent on it. I would still add a '(DEPRECATED)' into Fatal's ABSTRACT (line 3),
and add some deprecation metadata though (since you're using dzil, [Deprecated] can do this).

Depending on how ugly Fatal's code is, it could even print a runtime warning when it is used (like Any::Moose and other obsolete things do).

@toddr
Copy link
Collaborator Author

toddr commented Jan 16, 2020

@karenetheridge I'm closing this out since Fatal.pm is now shipped with autodie.

@toddr toddr closed this as completed Jan 16, 2020
@karenetheridge
Copy link
Member

since Fatal.pm is now shipped with autodie

It always was... that wasn't the issue, but rather that the code was in two separate files.
I still think that Fatal.pm should be more clearly marked as deprecated and not suitable for direct use.

@toddr toddr reopened this Jan 16, 2020
@toddr
Copy link
Collaborator Author

toddr commented Jan 16, 2020

Sorry. I was processing tickets too fast after the import to github and didn't notice we'd interacted on this.

How would you recommend we change the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants