Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing valueContent + decoding for Markdown in decodeValueContent seems incorrect. #437

Open
2 of 4 tasks
CJ42 opened this issue May 14, 2024 · 0 comments
Open
2 of 4 tasks
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CJ42
Copy link
Collaborator

CJ42 commented May 14, 2024

I'm submitting a...

  • bug report
  • feature request
  • question about the decisions made in the repository
  • question about how to use this project

Summary

Should add support to decode value content as Bytes and BitArray.

Also, the value content Markdown is treated the same way as String, which seems incorrect.

case 'String': {
return {
type: 'string',
encode: (value: string) => utf8ToHex(value),
decode: (value: string) => hexToUtf8(value),
};
}
case 'Markdown': {
return {
type: 'string',
encode: (value: string) => utf8ToHex(value),
decode: (value: string) => hexToUtf8(value),
};
}

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

@CJ42 CJ42 added enhancement New feature or request help wanted Extra attention is needed labels May 14, 2024
@CJ42 CJ42 self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant