Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require .devenv.yml extension with --file option (or document better). #90

Open
mforbes opened this issue Apr 6, 2019 · 2 comments

Comments

@mforbes
Copy link
Contributor

mforbes commented Apr 6, 2019

I spent quite a bit of time trying to figure out why the includes: section of my environment file was not being processed until stumbling on the apparent requirement that my environment file needs the .devenv.yml extension, even when explicitly specifying the --file option.

My preference would be to allow users to name the file whatever they like when explicitly checking, but if this is not possible, then perhaps at least emit a useful warning message if the file includes devenv features which will be ignored. This requirement was also not clear from the documentation or the emitted help message.

Thanks for a very useful tool.

@nicoddemus
Copy link
Member

Hi @mforbes,

Thanks for writing.

I don't recall why we chose to behave this way; after all environment.yml files are compatible with devenv, we just won't process missing sections when in a pure environment.yml file.

@prusse-martin do you record why we went in this direction?

@prusse-martin
Copy link
Member

No I don't.
I guess we wanted to be able to process environment.yml files as conda env does.
But except from valid comments in enviroment.yml having the possibility to spill content due jinja parsing I don't see a reason now that a clear counter example has been shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants