Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Integration of Charging Limits for EVSEs #852

Closed
Pietfried opened this issue Sep 5, 2024 · 0 comments · Fixed by #872
Closed

Refactor Integration of Charging Limits for EVSEs #852

Pietfried opened this issue Sep 5, 2024 · 0 comments · Fixed by #872
Assignees

Comments

@Pietfried
Copy link
Contributor

Pietfried commented Sep 5, 2024

Describe the problem

Currently the evse_manager interface provides a command set_external_limits to set external power or amp limits for an EVSE.

If the evse_manager interface is required by multiple modules (e.g. by OCPP and by the API module), this command can be used to be written from multiple sources, leading to an override of previous calls.

EVerest Domain

Charge Control, Energy Management, OCPP, OCPP1.6, OCPP2.0.1

Affected EVerest Module

OCPP
OCPP2.0.1
EvseManager
API

Describe your solution

WIP

The following changes are required in the EvseManager module:

  • In order to avoid overriding of charging limits from multiple sources, remove the command set_external_limits the evse_manager interface
  • Remove the var enforced_limits from the evse_manager interface

The following changes are required in the OCPP and API modules:

  • Add optional 0 to many requirement for external_energy_limits to these modules
  • Replace set_external_limits command to evse_manager requirement with the same command using the external_energy_limits requirement
  • Implement functionality to identify which external_energy_limits requirement belongs to which evse_id

Additional context

No response

@Pietfried Pietfried self-assigned this Sep 20, 2024
@Pietfried Pietfried linked a pull request Oct 7, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant