Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a TestGame with all audio formats #38

Open
21 tasks
fmatthew5876 opened this issue Apr 2, 2020 · 2 comments
Open
21 tasks

Make a TestGame with all audio formats #38

fmatthew5876 opened this issue Apr 2, 2020 · 2 comments

Comments

@fmatthew5876
Copy link

fmatthew5876 commented Apr 2, 2020

We should add a test to our test game that plays a BGM and SFX with all interesting variations of audio formats. I would suggest encoding the same song in each format and having an event play it in each one, so the user can listen for differences.

  • 8-bit mono PCM 44100
  • 16-bit mono PCM 44100
  • 8-bit mono ADPCM 44100
  • 16-bit mono ADPCM 44100
  • 8-bit mono PCM 48000
  • 16-bit mono PCM 48000
  • 8-bit mono ADPCM 48000
  • 16-bit mono ADPCM 48000
  • 8-bit mono PCM 22050
  • 16-bit mono PCM 22050
  • 8-bit mono ADPCM 22050
  • 16-bit mono ADPCM 22050
  • 16-bit stereo PCM 48000
  • 24-bit stereo PCM 48000
  • 24-bit stereo PCM 96000
  • CBR mp3
  • VBR mp3
  • Ogg variants?
  • Opus
  • Midi
  • Midi with loop event
@Ghabry
Copy link
Member

Ghabry commented Apr 2, 2020

Instead of 44100 better use 48000, is not a factor of 2 from 22050.

You forgot Opus.
Flac is not supported (well it is by libsndfile but we don't link libflac)

@fdelapena
Copy link
Contributor

For all of them, handling volume, panning, pitch, faders and continuation (changing values + playing the same song does not restart from the beginning but applying new values) for each is also worth. Pitch setting triggered some resampling bugs in the past.

Extension tests: priority, renamed files.

MIDI have some variants: format 0 and format 1, and there is some kind of format 2 out there.

VBR mp3 and maybe some CBR mp3 with ID3 tags are known to crash RPG_RT.exe due to codec limitations on some Windows setups (with and without custom ACM code packs installed). SDL2_mixer "recently fixed the music_type detection code to prevent crashing with some tags, we have(or had) some workarounds for this.

Though RPG Maker 200x don't support Ogg Vorbis, RGSS engines support Ogg LOOPSTART tag, and I recall some 2k/3 patches supporting this.

Games using Audieremony patch support tracker music loopstart, current libxmp fails on this, maybe test for them are worth for these few games, too.

@Ghabry Ghabry transferred this issue from EasyRPG/Player Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants