Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperation or removal of GUI #81

Open
Brandhoej opened this issue Oct 23, 2022 · 0 comments
Open

Seperation or removal of GUI #81

Brandhoej opened this issue Oct 23, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Brandhoej
Copy link
Contributor

Brandhoej commented Oct 23, 2022

The Location class contains coordinates which are expected to be used by the GUI. Looking at Reveaal it looks like the verification engine does not consider coordinates, but when parsing, a DummyLocation is used with constant coordinates. I think our Location class should not contain the coordinates for the GUI. As our protobuf specification states that the complete XML or JSON is transferred. We should not change the values of the locations when doing verification. We should instead ignore the coordinates and utilize save-component to allow the GUI to save the new coordinates of the locations. When creating a composed location (e.g. when doing conjunction) we should not calculate the new coordinates as the average, but instead tackle this issue when we need to display the result of a conjunction. For these reasons I think we should completely remove the coordinates from the Location. If we choose to have the coordinates in Location then I think a new class such as Position or Vector (A vector is often used to represent the position of an object) should be used to encapsulate the coordinates.

@Brandhoej Brandhoej mentioned this issue Oct 23, 2022
@Brandhoej Brandhoej added enhancement New feature or request question Further information is requested help wanted Extra attention is needed labels Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant