Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in names #98

Open
Brandhoej opened this issue Feb 12, 2023 · 0 comments
Open

Spaces in names #98

Brandhoej opened this issue Feb 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Brandhoej
Copy link
Contributor

Brandhoej commented Feb 12, 2023

In #94 locations are created with spaces in their name. Instead underscores should be used. Two comments reflecting this:

         There should be some unintended consequences of allowing spaces in names. I can't quickly think of any programming language that allows spaces in names.

Originally posted by @magoorden in #94 (comment)

I think it is dangerous to allow spaces in names. I think we should stick to having _ (underscores in the names).
--ulrik On 05/02/2023 08.56, Andreas K. Brandhøj wrote: @Brandhoej commented on this pull request.
________________________________ In src/logic/Refinement.java<#94 (comment)>:
@@ -432,8 +432,9 @@ private boolean checkActions(State state1, State state2, boolean isInput) {
Log.debug("create pairs failed"); if (RET_REF) { - Location ll = Location.createInconsistentLocation("inconsistent", 0, 0); - Location rl = Location.createInconsistentLocation("inconsistent", 0, 0); + Clock inconsistentClock = new Clock("inconsistent clock", "refinement"); I don't know how parsing is affected by spaces in names, but I would prefer to allow them. — Reply to this email directly, view it on GitHub<#94 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBJZC23UDCI6PYWGUQP7CDWV5MLDANCNFSM6AAAAAASOQYU7Y. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- ⬡ Ulrik Nyman, http://ulrik.blog.aau.dk, mobile: (+45) 40 89 21 56 ⩽ Associate Professor, Ph.D. Head of Studies at Department of Computer Science Deputy Head of Department, http://www.cs.aau.dk Education Coordinator for Software Aalborg University, http://www.aau.dk

We should disallow spaces in Location and possibly also Automaton names. This should probably be fixed after #97 has been introduced.

@Brandhoej Brandhoej added the bug Something isn't working label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant