[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] [$1000] No avatar tooltip on "Workspace invite members" page (after inviting)

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to settings-> worksapces
2. select any workspace and go to invite members
3. select invite -> choose few members -> next
4. ON add message page, hover over avatar and notice there is profile tooltip

Expected Result:

tooltip with profile description

Actual Result:

no Tooltip is shown on add message page after memeber invitation

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686832877081139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f7a8743c9a153776
• Upwork Job ID: 1669333458421411840
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f7a8743c9a153776

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[the-mold]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No tooltips are visible for avatars on the Add invite message page

What is the root cause of that problem?

We are missing some props on this component:

App/src/components/MultipleAvatars.js

Lines 125 to 128 in d396430

	<UserDetailsTooltip
	key={`stackedAvatars-${index}`}
	accountID={ReportUtils.getAccountIDForLogin(icon.name)}
	>

What changes do you think we should make in order to solve the problem?

This is POC for what I will change(I will test more):

<UserDetailsTooltip
                          key={`stackedAvatars-${index}`}
                          accountID={ReportUtils.getAccountIDForLogin(icon.name)}
                          fallbackUserDetails={{
                              displayName: ReportUtils.getDisplayNameForParticipant(icon.name),
                              login: lodashGet(icon, 'name', ''),
                              avatar: lodashGet(icon, 'source', ''),
                          }}
                      >

Result

What alternative solutions did you explore? (Optional)

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[$1000] No avatar tooltip on "Workspace invite members" page (after inviting)

What is the root cause of that problem?

App/src/libs/ReportUtils.js

Lines 830 to 832 in ff4df6b

	function getAccountIDForLogin(login) {
	return lodashGet(allPersonalDetails, [login, 'accountID'], '');
	}

Here getAccountIDForLogin is not working correctly, since new version of personalDetailsList's keys are not logins but ids.

What changes do you think we should make in order to solve the problem?

We should update this function to work correctly. We can find an object which has the same login as argument and return this object. Something like this:

function getAccountIDForLogin(login) {
    return lodashGet(
        _.find(allPersonalDetails, (item) => item.login === login),
        ['accountID'],
    );
}

What alternative solutions did you explore? (Optional)

We can also add accountID here, which is being supplied to MultipleAvatars .

App/src/libs/OptionsListUtils.js

Lines 159 to 164 in 320bcca

	return {
	source: UserUtils.getAvatar(userPersonalDetail.avatar, userPersonalDetail.accountID),
	type: CONST.ICON_TYPE_AVATAR,
	name: userPersonalDetail.login,
	};
	});

Then we can supply UserDetailsTooltip with accountID itself

[mananjadhav]

I think @alitoshmatov's proposal is more relevant to the current change and this would work.

@Beamanator All yours.

[alitoshmatov]

@mananjadhav what do you think of my alternative solution since it makes it simpler

[twisterdotcom]

Discussing which issue to fix this in here: #20822 (comment).

cc @alex-mechler and @Beamanator.

[twisterdotcom]

Okay, I'm going to close this issue and we'll resolve both issues in #20822 (comment).

@alitoshmatov could you propose your solution for both in there please? I will update the OP.

[Beamanator]

Sorry, opened the wrong one - closing and reopening #20822

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix avatar tooltip issues across the app #21026

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify / @greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix avatar tooltip issues across the app #21026

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify / @greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Issue already closed. Payments being dealt with from here: #20822 (comment)