-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment Due Sept 30 2024] [$250] Workspace - "Hmm... it's not here" page opens twice for an invalid link with a RHP #47331
Comments
Triggered auto assignment to @kadiealexander ( |
We think that this bug might be related to #vip-vsp |
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at {2023-10-06T12:30:00Z}. ProposalPlease re-state the problem that we are trying to solve in this issue."Hmm... it's not here" page opens twice for an invalid link with a RHP What is the root cause of that problem?On small screen, after going to When users go back, we will show ReportScreen (Not found) What changes do you think we should make in order to solve the problem?We're using withReportOrNotFound in report details page, report setting name, ...
In these screens, if the previous ReportScreen is not found, we should go to LHN when users press back button To do that:
What alternative solutions did you explore? (Optional)NA |
Job added to Upwork: https://www.upwork.com/jobs/~0147fe785445dbe8f8 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
@sobitneupane, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@sobitneupane What do you think about my proposal? |
@daledah Thanks for the proposal. Is it possible to not open the deeplink (in this case, details page) if user doesn't have access to the report? In that case we will be just showing the NotFoundPage for the report. |
@sobitneupane I don't think it's the expectation. If users open the details page by deeplink, they want to see the details page url. If we show the report url, it can cause the confusion. |
Thanks for the update @daledah Yup. It makes sense to open the deeplink especially in browsers. What will be the impact of your proposal in large screen devices which opens the details page in RHP? I don't think we should change the report (even if Not Found) when user presses back button in RHP. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@sobitneupane Thanks for your suggestion, I updated the proposal to handle |
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@Beamanator @sobitneupane @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@sobitneupane PR is ready. |
This issue has not been updated in over 15 days. @Beamanator, @sobitneupane, @kadiealexander, @daledah eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@Beamanator Is this ready for payment? |
Ooh def looks like it 😅 @kadiealexander can you help us out with payment here? |
Payouts due:
Upwork job is here. |
I'm going OOO so I'm adding someone to help with payment once the offer has been accepted. |
Triggered auto assignment to @trjExpensify ( |
Payment due in a couple of days. Can we get a checklist for this? Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.19-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4849349&group_by=cases:section_id&group_id=296763&group_order=asc
Issue reported by: Applause - Internal Team
Action Performed:
)
Expected Result:
"Hmm... it's not here" page should only open once
Actual Result:
"Hmm... it's not here" page opens twice for an invalid link with a RHP
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6570867_1723551281627.LGWI2032.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: