-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-29] [HybridApp] Open New Expensify /travel
when clicking on the HybridApp Trips
tab
#47734
Comments
Triggered auto assignment to @garrettmknight ( |
Similar to this PR https://github.com/Expensify/Mobile-Expensify/pull/12700, but will require some more work! |
cc @mateuuszzzzz @staszekscp @war-in - Here is a polish issue that can be worked on once we finish all other release items |
Still polish, prioritised correctly. |
Same as above. Will downgrade to |
Wow, I thought I had made this Monthly. |
Bumping @mateuuszzzzz @staszekscp @war-in to see if anyone wants this one! |
Hi! I'm gonna handle that one 👍 |
I prepared PRs they're in draft mode. I need to test Android tomorrow and then I should be able to move it to "ready for a review" |
Hi, I have and update. I would like to postpone this PR until we unify the process for booting React Native on both platforms. Currently, on iOS, the app boots on startup, which leads to platform-specific implementations to ensure compatibility on iOS. This issue also affects the current PR. I also spent some time today with @adamgrzybowski to figure out how we can integrate this feature with the current navigation. We have come up with a solution that works surprisingly well. |
Sounds good! |
We managed to change how we boot RN on iOS and it works without any crashes 🎉 I presume I will continue work on this issue on Monday/Tuesday |
I managed to fix all remaining issues in the blocking PR. I will continue work on Travel PR on Thursday 👍 |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
We reverted these PRs due to the linked deploy blockers, let's make sure to address them before trying to merge this again. Thanks! |
Also one thing I noticed, on the OldApp side of things we never renamed Trips to Travel, it'd be great to do that in this next round of PRs. |
/travel
when clicking on the HybridApp Trips
tab/travel
when clicking on the HybridApp Trips
tab
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-29. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary:
|
Hi! I have an update I prepared two PRs that should also fixes previous issues. I resolved the following issues:
I haven't addressed the iOS crash. I've just confirmed that this crash is not related to the Travel PR. It still appears in Crashlytics even after reverting the initial PRs (9.0.51.3). What's more, it looks like after introduction of Bridgeless mode on iOS (9.0.54.1). This crash has stopped appearing in Crashlytics, so I wouldn't introduce any additional fixes. cc: @AndrewGable |
Problem
We have a temporary fix in place for the new Travel feature but it has some limitations:
Solution
Travel
tab, redirect the user to New Expensify/travel
via thenavigateToNewDot
functiontryNewDot.classicRedirect
NVPBook Travel
in New Expensify we should open the browser as we do today, but we should take them back to Expensify Classic in the background.The intention here is to not take the user back to New Expensify once they return back to the Expensify app.
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: