-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Search - App freezes after cache and cookie clean of chat filter #49282
Comments
Triggered auto assignment to @Christinadobrzyn ( |
We think this issue might be related to the #wave-control |
Triggered auto assignment to @tylerkaraszewski ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Asking everyone in this PR to take a peek - #49258 |
I can't reproduce this issue on the latest main Screen.Recording.2024-09-17.at.00.17.28.mov |
Job added to Upwork: https://www.upwork.com/jobs/~021835730592300773674 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
I cannot reproduce in staging, it is testing feature |
Screen.Recording.2024-09-16.at.19.28.08.mp4 |
Multiple testers were able to reproduce this one. Let me check now again. |
I can reproduce it on staging https://expensify.slack.com/archives/C01GTK53T8Q/p1726505749566979 but I agree let's not block deploy on this |
Ah thank you for the update @Guccio163! Please let us know if there's anything we can do to help! |
I'm not able to reproduce the bug. @izarutskaya Could you please retest this? |
Asked QA to retest - https://expensify.slack.com/archives/C9YU7BX5M/p1728370749611919 |
Hi, I reached out to couple of colleagues from SWM to try and reproduce the bug, but no-one could. Nevertheless I see a big issue with |
Able to reproduce freeze. Also user need user need to clean cache multiple times #49282 (comment) is true. app.freeze.mp4 |
Thanks @kavimuru - @Guccio163 will you please let us know if you need anything else to continue investigating/testing? |
Hi @Christinadobrzyn, is there a specified number of refreshes needed for it to break? So far I got up to ~20 and I still cannot reproduce this one. Also: @kavimuru have you tested if selecting a cannot_reproduce_720.mov |
Asking @kavimuru to review the questions - https://expensify.slack.com/archives/C9YU7BX5M/p1728624548081019?thread_ts=1728370749.611919&cid=C9YU7BX5M |
@Guccio163 @Christinadobrzyn App freezes for me right after " Reset cache and restart" @ Recording.2048.mp4 |
@tylerkaraszewski @Christinadobrzyn @rayane-djouah @Guccio163 this issue is now 4 weeks old, please consider:
Thanks! |
People are working on it melvin. |
@Guccio163 Feel free to let us know how we can help with testing this #49282 (comment) - TY! |
Hi @kavimuru, could you please attach some technical specification of the device you're reproducing on? I've noticed that's MacBook/iMac, but I'm working on one too, so maybe it's the specification differences. |
@Guccio163 - I was able to reproduce the bug. To do so, we need to resize the window to a size smaller than the screen size. Untitled.movConsole Logs: dev.new.expensify.com-1728983762370.log |
Thanks for the insight @rayane-djouah, I'll try this one in a moment! 🫶 |
Hi @Christinadobrzyn, I'm coming with my conclusions on this issue: There's a list of tests I performed here to try and reproduce the bug: Reported bug behaviour:
Current observed behaviour (One of two, non-deterministic) :
Moreover I'm pretty much sure that this bug isn't connected to Search at all; To illustrate the non-deterministic nature of this bug, below are recordings of app behaviour with and without the search-related steps:
Please notice that no matter with or without filters, app behaves the same in one of 2 defined behaviours above:Staging: filters then cache clear - loading loopsacu_staging_480.movStaging: filters then cache clear - loading normallysacl_staging_480.movStaging: Just cache clear - loading loopcu_staging_480.movStaging: Just cache clear - loading normallycl_staging_720.movAlso, all these results are possible to spot in Local environment too:Local: filters then cache clear - loading loopsearch_and_clear_unfinished_480.movLocal: filters then cache clear - loading normallysearch_and_clear_load_480.movLocal: Just cache clear - loading loopclear_unfinished_480.movLocal: Just cache clear - loading normallyclear_load_480.movAs a final addition, exactly the same infinite loading happens (non-deterministic) right after logging in:Staging: Right after logging in - loading loopafter_logging_unfinished_480.movIn my opinion incorrect behaviour isn't linked to Search and is purely matter of "Clear cache and restart" button; Maybe the contributor that added this feature or someone with bigger Onyx knowledge could take this and dive into the button's functionality? |
Hi @Guccio163! Thank you so much for the thorough review. It sounds like we need to find an Onyx person to investigate more. I think @kidroca does Onyx stuff but I don't know if it relates to this kind of job. @tylerkaraszewski or @rayane-djouah do you know who else we might be able to reach out to about this? |
@Christinadobrzyn, the feature was worked on by @TMisiukiewicz in this PR: #35306 |
Awesome, thanks @rayane-djouah! I reached out to the Callstack team to see if they might have someone with Onyx experience to help! https://expensify.slack.com/archives/C03UK30EA1Z/p1729654603736149 |
Hey, I'll take a look on this later this week 👍 |
Awesome! Thank you @TMisiukiewicz! |
Started investigating it, I couldn't reporoduce it based on the steps provided in the issue. However, the browser tab hang to me once when I did clear a couple of times, it felt like each next clear is slowing down the app, however I haven't done any measurements yet. I'll continue looking into that on Monday |
I was able to reproduce it with 6x CPU throttling enabled in devtools. However, it was impossible to record a profiling trace because the devtools freezes together with the app 😞 One thing I noticed is the fact that my app hangs every time after |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.35-7
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #49258
Email or phone of affected tester (no customers): applausetester+bp0916w@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition; logged in application.
Expected Result:
App doesn't crash. App doesn'r freeze
Actual Result:
App is freezed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6605499_1726494649775.filter_chat.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: