-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-24] [$250] Room - Code block mark down after a space is not applied #49894
Comments
Triggered auto assignment to @abekkala ( |
@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Editing an inline code block with space-only content will remove all the spaces inside it. What is the root cause of that problem?In #48101, we allow spaces only inside an inline code block, for example:
We do that by replacing the whitespace with In the new task description page, the saved description will be converted to the HTML first and then converted back to the markdown.
However, when submitting the form, the description value here contains the inline code block with empty content, all the App/src/pages/tasks/NewTaskDescriptionPage.tsx Lines 43 to 44 in d187665
That's because of the App/src/components/Form/FormProvider.tsx Line 168 in d187665
In App/src/libs/ValidationUtils.ts Line 460 in d187665
And Lines 35 to 39 in d187665
Why this doesn't happen on the room description page? That's because, on the room description page, we manually managed the input state. So, when submitting, we use the state value instead of the form provider values. App/src/pages/RoomDescriptionPage.tsx Line 43 in d187665
App/src/pages/RoomDescriptionPage.tsx Lines 57 to 63 in d187665
If we use the form passed values, then the issue will happen too.
What changes do you think we should make in order to solve the problem?Since we replace whitespace with
What alternative solutions did you explore? (Optional)I think we shouldn't include Lines 41 to 50 in d187665
This way, we don't need to remove the nbsp. Lines 35 to 39 in d187665
|
@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@abekkala Eep! 4 days overdue now. Issues have feelings too... |
@abekkala Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Job added to Upwork: https://www.upwork.com/jobs/~021843721884804343746 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach ( |
@bernhardoj 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
PR is ready cc: @ZhenjaHorbach |
Triggered auto assignment to @twisterdotcom ( |
@twisterdotcom I'll be ooo until Mon Oct 21 STATUS: proposal selected, PR created but not yet deployed to productionPayment Summary [date, TBD]:
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I'm back from ooo - unassigning @twisterdotcom |
PAYMENT SUMMARY FOR OCT 24
|
Requested in ND. |
@ZhenjaHorbach, can you complete the checklist above so that I can issue payment today? Thanks! |
Expensify/expensify-common#797
https://github.com/Expensify/expensify-common/pull/797/files#r1814977410
NA
|
Thanks for the reminder ! |
@ZhenjaHorbach payment sent and contrct ended - thank you! 🎉 |
Pasting summary once more as it got a little buried above: PAYMENT SUMMARY FOR OCT 24
|
@carlosmiceli @abekkala Be sure to fill out the Contact List! |
$250 approved for @bernhardoj |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Code block mark down must be applied after a space
Actual Result:
Code block mark down after a space applied in room description but not in task description
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6617983_1727482223916.Screenrecorder-2024-09-28-05-29-03-760_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcom / @abekkalaThe text was updated successfully, but these errors were encountered: