-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] De-dupe AddComment, EditComment, and DeleteComment requests #50074
Comments
cc @gedu |
Hey, I'm Edu from Callstack, I can take this one |
There are several obstacles to achieve this.
The obstacle here is that if the request fails after replace call, it will show wrong comment.
This is tricky as we are now reducing the queue size. |
isn't that the case today with any |
Going on parental leave. @gedu @mountiny @shubham1206agra I leave this in your capable hands. My parting note is to please use as many automated tests to cover this change as possible 👍🏼 |
I just made a PR for |
@shubham1206agra I'm making me a diagram, and I was thinking, what about a reaction, |
Yes that is true |
@shubham1206agra also just to make sure, if I edit -> create a thread -> add message in that thread -> delete original message, this is the final state. In such case I only delete the |
Yes |
There's another case No request should be made in this case |
Ohh, yeah, so nothing happens, no new thread is created and no new message is added into that thread. Cool, I'm adding this case too |
Just to make sure, these cases can happen at any time, not just offline. Given that the queue is being processed sequentially, the delete could occur at any time, and I have to prevent those messages from being sent, right? |
@shubham1206agra Also I was thinking, if I create a thread -> message -> message -> delete last message -> delete thread. delete_message.mp4 |
Can you report the bug in slack? |
How can I do it? I don't have access to the prompt /bug |
You can just copy the template and fill it manually |
Triggered auto assignment to @bfitzexpensify ( |
@mountiny After a talk with @zirgulis that point we will tackle in a new PR, not in the same one of multiple |
Thanks! |
Job added to Upwork: https://www.upwork.com/jobs/~021848400026446902359 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@mountiny I did the second item, and I'm seeing this behaviour, for a couple of seconds, until the response is back and then it rerenders, you can see the Given that the updateComment_addComment.mp4 |
@gedu I think from UX it would be best not to show it but I would not block on this if its too complex to achieve not showing edited label |
Problem
When we make unnecessary network requests, it slows down the app and contributes to higher traffic on our servers. In particular:
EditComment
requests, only the last one will take effectAddComment
and any number ofEditComment
requests, the result would be the same as oneAddComment
with the content of the finalEditComment
AddComment
followed by aDeleteComment
, the end result is the same as not sending any network requests at allEditComment
request followed by aDeleteComment
, the end result is the same as only sending theDeleteComment
Solution
De-dupe the network requests!
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307The text was updated successfully, but these errors were encountered: