[$250] [HOLD for payment 2024-10-24] QBO - Some Customer/projects values are trigger an error that disappears

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: workspace with connected QBO integration. Classes and Customers/Projects are imported via Import tab. 'Members must tag all expenses' toggle is ON.

1. Go to workspace chat
2. Click + > Submit expense > Manual
3. Enter amount and Merchant > Submit
4. Open expense report
5. Choose Category and Classes values
6. Click on Customers/projects > choose Coke Drink Canada:Big Project or Coke Drink Canada:Test Test

Expected Result:

Value is applied without error

Actual Result:

An error 'Customers/Projects no longer valid' briefly appears. Sometimes an error stays until user chose another value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622432_1727892498454.bandicam_2024-10-02_20-57-12-446.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849320215635409078
• Upwork Job ID: 1849320215635409078
• Last Price Increase: 2024-10-24

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kadiealexander]

cc @arosiclair I know you worked on QBO recently!

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-03 05:24:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Customer/projects values trigger an error that disappears. This error is more visible in offline mode.

What is the root cause of that problem?

In this function we get the Violations for independent tags

App/src/libs/Violations/ViolationsUtils.ts

Line 81 in e61ee7f

function getTagViolationForIndependentTags(policyTagList: PolicyTagLists, transactionViolations: TransactionViolation[], transaction: Transaction) {

And here we split the tag based on the colon. The problem is when we have a tag ``

App/src/libs/Violations/ViolationsUtils.ts

Line 83 in e61ee7f

const selectedTags = transaction.tag?.split(CONST.COLON) ?? [];

The problem is when we have a tags with this structure transaction?.tag will be `Jane\:expensify test 1:testing 1` and the colon split will divide this tag into 3 based on the colon `['Jane\', 'expensify test 1', 'testing 1']`

so when in here we try to match it with policy tags it will return an error. This error is fixed when we get the response from BE

App/src/libs/Violations/ViolationsUtils.ts

Line 113 in e61ee7f

const isTagInPolicy = Object.values(tags).some((tag) => tag.name === selectedTag && !!tag.enabled);

What changes do you think we should make in order to solve the problem?

Instead of using transaction.tag?.split(CONST.COLON) we can use getTagArrayFromName this will split the string correctly

App/src/libs/Violations/ViolationsUtils.ts

Line 83 in e61ee7f

const selectedTags = transaction.tag?.split(CONST.COLON) ?? [];

We can do something like this

 const selectedTags = TransactionUtils.getTagArrayFromName(transaction?.tag ?? '')

Now split will be ['Jane\\:expensify test 1', 'testing 1']

Before

Screen.Recording.2024-10-03.at.10.19.06.AM.mov

After

Screen.Recording.2024-10-03.at.10.18.17.AM.mov

What alternative solutions did you explore? (Optional)

Not recommended but alternate solution will be only in this loop we declare const selectedTags = TransactionUtils.getTagArrayFromName(transaction?.tag ?? '') and use it only in this loop instead of getTagViolationForIndependentTags function

App/src/libs/Violations/ViolationsUtils.ts

Line 110 in e61ee7f

for (let i = 0; i < policyTagKeys.length; i++) {

[arosiclair]

cc @arosiclair I know you worked on QBO recently!

Sorry I don't have much info to give on this issue specifically. Seems like a legit bug though.

[allroundexperts]

@Nodebrute's proposal looks good to me. The RCA seems to be correct and the solution makes sense as well. Let's go with them.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

Looks good 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allroundexperts]

Checklist

1. https://github.com/Expensify/App/pull/37461/files#r1807953238
2. Add violation logic for multi level tags #37461
3. N/A
4. I think that this is really an edge case, that was specific to QBO integration. As such, we can skip the test here.

[MonilBhavsar]

I think we should add the tests that uses special tag names with colon inside it, as this bug made to production unnoticed

[kadiealexander]

@allroundexperts can you share test instructions that test for @MonilBhavsar's case here? Thanks!

[melvin-bot]

Current assignee @kadiealexander is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849320215635409078

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[kadiealexander]

Payouts due:

• Contributor: $250 @Nodebrute (offer link)
• Reviewer: $250 @allroundexperts via manual request

Upwork job is here.

[kadiealexander]

Reassigning to have someone raise a GH to get these requested testing steps into testrail once they're written, as I'm heading OOO!

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@allroundexperts, @MonilBhavsar, @bfitzexpensify, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bfitzexpensify]

Bump @allroundexperts

[allroundexperts]

Regression test

1. Create a workspace, and enable tags + categories.
2. Add a tag, and category named as "test:new:exfy".
3. Submit an expense to the workspace, and select the above create tag and category.
4. Verify that no error occurs and the expense gets submitted successfully.

Do we 👍 or 👎 ?