Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Chats for All][HOLD #49344] Default QAB to primary workspace if no value #50728

Open
puneetlath opened this issue Oct 14, 2024 · 6 comments
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Oct 14, 2024

In #49344 we are going to make it possible to submit to any workspace, even if you don't have the workspace chat locally.

We also want to make it so that any user that is a member of a policy has a default value for their QAB. So what we should do is update the QAB behavior so that if the nvp doesn't have any data set, and the user is on any group policies, then we set the default value for the QAB to be to submit to their primary group policy, which is stored in nvp_expensify_activePolicyID.

Slack discussion: https://expensify.slack.com/archives/C07NMDKEFMH/p1728585368177889?thread_ts=1728418936.029729&cid=C07NMDKEFMH

@puneetlath puneetlath added Weekly KSv2 NewFeature Something to build that is a new item. labels Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 14, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 14, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@ishpaul777
Copy link
Contributor

👋 I'll take this after #49344

@flaviadefaria flaviadefaria changed the title [HOLD #49344] Default QAB to primary workspace if no value [Workspace Chats for All] [HOLD #49344] Default QAB to primary workspace if no value Oct 21, 2024
@puneetlath puneetlath changed the title [Workspace Chats for All] [HOLD #49344] Default QAB to primary workspace if no value [Workspace Chats for All] Default QAB to primary workspace if no value Oct 21, 2024
@puneetlath
Copy link
Contributor Author

@ishpaul777 taking this off hold now.

@puneetlath puneetlath added Daily KSv2 and removed Weekly KSv2 labels Oct 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2024
@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
@puneetlath
Copy link
Contributor Author

Back to weekly. We had to revert the previous PR.

@puneetlath puneetlath changed the title [Workspace Chats for All] Default QAB to primary workspace if no value [Workspace Chats for All][HOLD #49344] Default QAB to primary workspace if no value Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: First Cohort
Development

No branches or pull requests

4 participants