Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal card - can't edit expense details as approver or submitter #51144

Open
1 of 8 tasks
m-natarajan opened this issue Oct 20, 2024 · 7 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @yuwenmemon
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729273824647889

Action Performed:

Prerequisite: connect a US personal card in OldDot settings.

  1. Create a smart scanned expense using a personal card on an instant submit policy
  2. Have the receipt get matches to an imported transaction from the personal card.
  3. Log in as the approver for the request, try to edit the amount
  4. Log in as the submitter for the request, try to edit the amount

Expected Result:

The approver should be able to edit the amount.

Actual Result:

The approver cannot edit the amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screenshot 2024-10-18 at 10 48 43 AM
Screenshot 2024-10-18 at 10 48 25 AM

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 20, 2024
Copy link

melvin-bot bot commented Oct 20, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@trjExpensify trjExpensify changed the title Can't edit expense details as approver or submitter Personal card - can't edit expense details as approver or submitter Oct 21, 2024
@trjExpensify
Copy link
Contributor

I'm going to pull the trigger on this again and hope someone in the US gets assigned to triage, as I can't add a personal card to test import.

@trjExpensify trjExpensify removed their assignment Oct 22, 2024
@trjExpensify trjExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@trjExpensify
Copy link
Contributor

Boom. EXACTLY the person we needed.

@mallenexpensify
Copy link
Contributor

Checking on in the Slack thread (cuz more 👀 there)

I got assigned as the BZ, what's easiest/best way to test this?
I added my CC to my main/work Expensify account is there a way to enable instant submit for NewDot Test - Expensify coffee?
(I started by trying to setup a brand new test account but kept going down 🐰🕳️s)

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Oct 25, 2024

Posted here

As BZ on the bug, I'm thinking...

  1. Follow thread with Garrett and Jenna about delegates getting updated. (done)
  2. Once my approver is updated, follow repro steps and ping Cole to test to see if he can edit the amount
  3. Report on the GH and in this thread.

Copy link

melvin-bot bot commented Oct 28, 2024

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue
Projects
None yet
Development

No branches or pull requests

3 participants