Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Cannot submit survey and open Expensify Classic after pressing the “Enter” key. #51145

Open
1 of 8 tasks
m-natarajan opened this issue Oct 20, 2024 · 13 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9..0.51-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729337665245359

Action Performed:

  1. Open the profile and switch to Expensify Classic.
  2. Select a reason and press Enter.
  3. Type a response and press Enter.
  4. Press Enter to submit the response.

Expected Result:

The response should be submitted and open Expensify Classic.

Actual Result:

Nothing happens at the "exit survey" step when the Enter key is pressed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Screen.Recording.2024-10-19.at.18.21.11.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848188969730042061
  • Upwork Job ID: 1848188969730042061
  • Last Price Increase: 2024-10-21
  • Automatic offers:
    • suneox | Reviewer | 104563571
    • nkdengineer | Contributor | 104563573
Issue OwnerCurrent Issue Owner: @
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 20, 2024
Copy link

melvin-bot bot commented Oct 20, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@nkdengineer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot submit survey and open Expensify Classic after pressing the “Enter” key.

What is the root cause of that problem?

We don't pass props pressOnEnter in this button

What changes do you think we should make in order to solve the problem?

We should add props pressOnEnter as true in this button

What alternative solutions did you explore? (Optional)

NA

@jliexpensify
Copy link
Contributor

@m-natarajan can you attach the video please?

@suneox
Copy link
Contributor

suneox commented Oct 21, 2024

Screen.Recording.2024-10-19.at.18.21.11.mp4

@jliexpensify I’ve reported this issue and have more context on it, so I can assist with reviewing the proposal as a C+.

@jliexpensify jliexpensify added the External Added to denote the issue can be worked on by a contributor label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021848188969730042061

@jliexpensify
Copy link
Contributor

Thanks, have assigend you as I can reproduce.

@melvin-bot melvin-bot bot changed the title Cannot submit survey and open Expensify Classic after pressing the “Enter” key. [$250] Cannot submit survey and open Expensify Classic after pressing the “Enter” key. Oct 21, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Current assignee @suneox is eligible for the External assigner, not assigning anyone new.

@suneox
Copy link
Contributor

suneox commented Oct 21, 2024

@nkdengineer proposal LGTM

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2024
@NikkiWines
Copy link
Contributor

Oh sorry, I missed this assignment! Agreed, @nkdengineer's proposal looks good 👍

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Oct 23, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2024
@nkdengineer
Copy link
Contributor

@suneox this PR is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

5 participants