[$250] Update all enable/disable workspace editor menu items to use more appropriate icons.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729696426720769

Action Performed:

1. Go to staging.new.expensify.com
2. Settings > Workspace
3. Enable and disable distance rates, categories, tags, taxes, etc in the workspace editor

Expected Result:

Update all of these options to use our checkmark icon for enabling and our close icon for disabling

Actual Result:

For enabling and disabling distance rates, categories, tags, taxes, etc in the workspace editor, we use the document slash and document icons

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850952147214906851
• Upwork Job ID: 1850952147214906851
• Last Price Increase: 2024-10-28

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

Nice, good thinking here!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850952147214906851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[klajdipaja]

I am confused as @jayeshmangwani is assigned as c+ but his proposal is correct. Is this up for grabs still? I could work as the contributor here.

[jayeshmangwani]

Hey @klajdipaja ! I submitted a proposal before being assigned here as C+. Issue is still open for proposals, so feel free to add one if you have any ideas. I'll Hide my comment

[klajdipaja]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to update all enabled/disabled workspace editor menu items to use more appropriate icons.

What is the root cause of that problem?

It's just a UI Enhancement

What changes do you think we should make in order to solve the problem?

This is a straightforward change, and if we decide to address it externally, here’s my proposal:

On the pages listed below, we're currently using Expensicons.Document and Expensicons.DocumentSlash. These should be replaced with Expensicons.Checkmark and Expensicons.Close respectively.

WorkspaceCategoriesPage
PolicyDistanceRatesPage
ReportFieldsListValuesPage
WorkspaceTagsPage
WorkspaceViewTagsPage
WorkspaceTaxesPage

What alternative solutions did you explore? (Optional)

[jayeshmangwani]

It's a straightforward icons update. We can assign this issue to @klajdipaja with the selected proposal #51361 (comment).

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.