-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify #51524
Comments
Triggered auto assignment to @zanyrenney ( |
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Release 1 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hidden is shown in the workspace member after moving the expense to a new workspace. What is the root cause of that problem?When we select Business bank account as the payment method, we will optimistically create a new workspace based on the IOU report data. App/src/components/KYCWall/BaseKYCWall.tsx Lines 110 to 111 in 652d2ff
The problem is, we are trying to create the workspace member from the IOU report App/src/libs/actions/Policy/Policy.ts Line 2134 in 652d2ff
App/src/libs/actions/Policy/Policy.ts Lines 2184 to 2191 in 652d2ff
However, What changes do you think we should make in order to solve the problem?There was previously a plan to get the employee email from the personal detail, but I decided to just default it to an empty string because, at that time, the email wasn't really needed. Previously, the policy member is keyed by their accountID. So, the solution is to get the employee's email from the personal details data.
I don't think the personal detail login would be undefined, but we can avoid creating the employee optimistic data if |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5134693
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
4/ [User B] Click Pay with Expensify
Expected Result:
There will be no "Hidden" member
Actual Result:
"Hidden" member appears in Members list when the workspace is created via Pay with Expensify in p2p expense
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6645865_1729878847118.20241026_014655.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: