-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] iOS - Categories - Offline indicator overlaps with home bar in Default spend categories page #51544
Comments
Triggered auto assignment to @isabelastisser ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Offline indicator overlaps with the iOS home bar briefly after closing keyboard. What is the root cause of that problem?The category selector page uses a Modal and inside the modal, we have a padding bottom added to avoid the home bar overlapping. But, if a keyboard is shown, we won't apply the padding-bottom. App/src/components/Modal/BaseModal.tsx Line 196 in 5103b4b
It was added to fix this issue where there is an extra space at the bottom when the keyboard is shown, so they apply the padding-bottom only if the keyboard is closed. So, in this issue, when the keyboard opens, the padding-bottom isn't applied and when we close the keyboard, the offline indicator will overlap with the home bar for a while until the keyboard state changes to "closed". What changes do you think we should make in order to solve the problem?Applying the padding-bottom conditionally based on the keyboard state is only needed when the keyboard-avoiding view is enabled. If it's disabled, then the modal content won't be pushed above the keyboard, so we won't see the padding-bottom either. So, the first solution is to always apply the padding-bottom if the keyboard avoiding view is disabled.
App/src/components/Modal/BaseModal.tsx Line 47 in 5103b4b
And because we don't need to avoid keyboard for the category selector modal, we can just disable it from the ScreenWrapper too. App/src/pages/workspace/distanceRates/CategorySelector/CategorySelectorModal.tsx Lines 33 to 48 in 5103b4b
What alternative solutions did you explore? (Optional)Wrap the children with SafeAreaView and remove the manual safe area padding calculation. App/src/components/Modal/BaseModal.tsx Lines 188 to 203 in 5103b4b
App/src/components/Modal/BaseModal.tsx Lines 272 to 277 in 5103b4b
<SafeAreaView style={styles.flex1}>
|
Job added to Upwork: https://www.upwork.com/jobs/~021850900545784411884 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
@muttmuure, does this issue belong to [#whatsnext] #quality? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Offline indicator will not overlap with home bar after dismissing the keyboard
Actual Result:
Offline indicator overlaps with home bar briefly after dismissing the keyboard
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6647469_1730045538081.ScreenRecording_10-28-2024_00-05-58_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307The text was updated successfully, but these errors were encountered: