-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Submit expense RHP doesn't include workspaces from Track flow #51552
Comments
Job added to Upwork: https://www.upwork.com/jobs/~021850835832011853233 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Triggered auto assignment to @sonialiap ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Submit expense RHP doesn't include workspaces from Track flow What is the root cause of that problem?We do not include here for track expense
What changes do you think we should make in order to solve the problem?We should include track expense as well includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT || iouType === CONST.IOU.TYPE.TRACK) && action !== CONST.IOU.ACTION.SUBMIT, ResultWhat alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Submit expense RHP doesn't include workspaces from Track flow What is the root cause of that problem?We are currently not allowing workspaces through the
and in participants we are not including workspaces if the action is submit
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
Problem:
When you Track an expense, you can then submit it to someone. However, the list of contacts shown on this screen differs from the same contacts you would see if you first chose Submit expense from global create.
Track sees this:
Submit sees this:
Solution:
Let's make sure the Submit expense RHP flow looks identical no matter if you chose Track or Submit. This will fix the inconsistency in the product, and it also helps our chances for conversion as it unhides submitting an expense to a workspace from this flow.
cc @anmurali @JmillsExpensify to file this one, I think it is a #convert issue
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: