Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnBotJava font size setting seems to have no effect #841

Open
pmichaud opened this issue Nov 20, 2023 · 5 comments
Open

OnBotJava font size setting seems to have no effect #841

pmichaud opened this issue Nov 20, 2023 · 5 comments

Comments

@pmichaud
Copy link

I don't know when this changed, but the "Font Size" setting in the OnBotJava editor no longer seems to have an effect.

I've tried changing the font size to values as low as 12 and as high as 40 and the font always appears to be the same size on my browser (Google Chrome / Kubuntu Linux).

I know the font size setting worked in previous versions of OnBotJava. Being able to set a large font size is important whenever I'm trying to teach/present OnBotJava programming in classroom or online workshop environments (e.g. for projection).

Thanks,

Pm

@dmssargent
Copy link

I can confirm that’s a real bug in the current system. We’ll mark that to be fixed in a future release.

What Robot Controller deployment model are you using? OnBotJava and Android Studio or OnBotJava downloaded from the official sources?

One more question, since, it’s also broken at the moment, is did you ever notice what happened with the font size when you adjust the window in previous versions of OnBotJava? Do you miss that behavior this year?

@pmichaud
Copy link
Author

Thanks for the confirmation -- I had been wondering if it was "just me" somehow.

The font-size setting seems to have no effect in either deployment model. I have some Control Hubs that have OnBotJava installed via the REV hardware client, and other Control Hubs that have the app installed from Android Studio; both exhibit the same font size regardless of the font size specified in OnBotJava settings.

My recollection is that changing the size of the window didn't affect the font size at all -- in short, it did exactly what I expected (which is to keep the font-size as specified, and not to change it based on the size of the window).

Thanks!

Pm

@dmssargent
Copy link

My recollection is that changing the size of the window didn't affect the font size at all -- in short, it did exactly what I expected (which is to keep the font-size as specified, and not to change it based on the size of the window).

Thanks for the info! That's appreciated so we can fix this so it behaves as you expect.

Do you need a workaround in OnBotJava until we have a proper bug fix released?

@pmichaud
Copy link
Author

pmichaud commented Jan 4, 2024

I meant to answer this earlier -- I don't immediately need a workaround. I can cope well enough until a proper bug fix is available.

Pm

@dmssargent
Copy link

Thanks for the heads up:

If you end up needing a fix sooner rather than later, you can save the following as a bookmark to run when you need to fix OnBotJava font sizes:

javascript:((f) => (f.location.href.includes('/java/editor.html')) && f.$('.editor-font').css('font-size', `${f.env.settings.get('fontSize')}px`))(window.frames[0])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants