Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement of Parcellation.find_regions (and Atlas.find_regions) and it's functionality requires clarification #513

Open
AhmetNSimsek opened this issue Nov 20, 2023 · 0 comments
Open

Placement of Parcellation.find_regions (and Atlas.find_regions) and it's functionality requires clarification #513

AhmetNSimsek opened this issue Nov 20, 2023 · 0 comments
Labels
maintenance Not a bug or breaking issue. Code maintenance related.

Comments

@AhmetNSimsek
Copy link
Collaborator

Q1: Given a parcellation instance p, where should p.find_regions search regions for?
Q2: If the functionality is preserved, wouldn't it be more suitable if it is a method of parcellation.py? (Goal is to prevent access to the method from an instance since find is the designated search method.)
@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Nov 20, 2023
@AhmetNSimsek AhmetNSimsek mentioned this issue Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AhmetNSimsek