Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maint] Factory.from_json overwrites filename attribute, if exists #581

Open
xgui3783 opened this issue Mar 12, 2024 · 0 comments
Open

[maint] Factory.from_json overwrites filename attribute, if exists #581

xgui3783 opened this issue Mar 12, 2024 · 0 comments
Labels
maintenance Not a bug or breaking issue. Code maintenance related.

Comments

@xgui3783
Copy link
Member

Currently, the usage of Factory.from_json overwrites filename attribute

In future, this can break in subtle ways, that's hard to catch.
@xgui3783 xgui3783 added the maintenance Not a bug or breaking issue. Code maintenance related. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xgui3783