From c29beafe9734b55c77733479d2308ec4494072c4 Mon Sep 17 00:00:00 2001
From: Ali <115415312+xogoodnow@users.noreply.github.com>
Date: Tue, 1 Oct 2024 07:57:43 +0330
Subject: [PATCH] [stable/goldilocks] Monitoring all namespaces out of the box
 (#1509)

* Monitoring all namespaces by default

It was not well mentioned within the documentation.

* Updated chart version

Updated chart version

* No multi line comments

* Update Chart.yaml

* Apply suggestions from code review

* Update README.md  for goldilocks chart

added  "on-by-default" flag

* docs: run helm-docs

---------

Co-authored-by: Vitor Rodrigo Vezani <vitor.vezani@fairwinds.com>
Co-authored-by: Andy Suderman <andy@fairwinds.com>
Co-authored-by: Andy Suderman <andy@suderman.dev>
---
 stable/goldilocks/Chart.yaml  | 2 +-
 stable/goldilocks/README.md   | 4 ++--
 stable/goldilocks/values.yaml | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/stable/goldilocks/Chart.yaml b/stable/goldilocks/Chart.yaml
index 777390277..c446ef309 100644
--- a/stable/goldilocks/Chart.yaml
+++ b/stable/goldilocks/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 appVersion: "v4.13.0"
-version: 9.0.0
+version: 9.0.1
 kubeVersion: ">= 1.22.0-0"
 description: |
   A Helm chart for running Fairwinds Goldilocks. See https://github.com/FairwindsOps/goldilocks
diff --git a/stable/goldilocks/README.md b/stable/goldilocks/README.md
index b42568980..595682283 100644
--- a/stable/goldilocks/README.md
+++ b/stable/goldilocks/README.md
@@ -78,7 +78,7 @@ This will completely remove the VPA and then re-install it using the new method.
 | controller.rbac.extraClusterRoleBindings | list | `[]` | A list of ClusterRoles for which ClusterRoleBindings will be created for the ServiceAccount, if enabled |
 | controller.serviceAccount.create | bool | `true` | If true, a service account will be created for the controller. If set to false, you must set `controller.serviceAccount.name` |
 | controller.serviceAccount.name | string | `nil` | The name of an existing service account to use for the controller. Combined with `controller.serviceAccount.create` |
-| controller.flags | object | `{}` | A map of additional flags to pass to the controller |
+| controller.flags | object | `{}` | A map of additional flags to pass to the controller. For monitoring all namespaces out of the box, add the following flag "on-by-default: true" |
 | controller.logVerbosity | string | `"2"` | Controller log verbosity. Can be set from 1-10 with 10 being extremely verbose |
 | controller.nodeSelector | object | `{}` | Node selector for the controller pod |
 | controller.tolerations | list | `[]` | Tolerations for the controller pod |
@@ -99,7 +99,7 @@ This will completely remove the VPA and then re-install it using the new method.
 | dashboard.service.type | string | `"ClusterIP"` | The type of the dashboard service |
 | dashboard.service.port | int | `80` | The port to run the dashboard service on |
 | dashboard.service.annotations | object | `{}` | Extra annotations for the dashboard service |
-| dashboard.flags | object | `{}` | A map of additional flags to pass to the dashboard |
+| dashboard.flags | object | `{}` | A map of additional flags to pass to the dashboard. For monitoring all namespaces out of the box, add the following flag "on-by-default: true". |
 | dashboard.logVerbosity | string | `"2"` | Dashboard log verbosity. Can be set from 1-10 with 10 being extremely verbose |
 | dashboard.excludeContainers | string | `"linkerd-proxy,istio-proxy"` | Container names to exclude from displaying in the Goldilocks dashboard |
 | dashboard.rbac.create | bool | `true` | If set to true, rbac resources will be created for the dashboard |
diff --git a/stable/goldilocks/values.yaml b/stable/goldilocks/values.yaml
index 6751693aa..69f8e32d8 100644
--- a/stable/goldilocks/values.yaml
+++ b/stable/goldilocks/values.yaml
@@ -46,8 +46,7 @@ controller:
     create: true
     # controller.serviceAccount.name -- The name of an existing service account to use for the controller. Combined with `controller.serviceAccount.create`
     name:
-
-  # controller.flags -- A map of additional flags to pass to the controller
+  # controller.flags -- A map of additional flags to pass to the controller. For monitoring all namespaces out of the box, add the following flag "on-by-default: true"
   flags: {}
   # controller.logVerbosity -- Controller log verbosity. Can be set from 1-10 with 10 being extremely verbose
   logVerbosity: "2"
@@ -108,7 +107,7 @@ dashboard:
     port: 80
     # dashboard.service.annotations -- Extra annotations for the dashboard service
     annotations: {}
-  # dashboard.flags -- A map of additional flags to pass to the dashboard
+  # dashboard.flags -- A map of additional flags to pass to the dashboard. For monitoring all namespaces out of the box, add the following flag "on-by-default: true".
   flags: {}
   # dashboard.logVerbosity -- Dashboard log verbosity. Can be set from 1-10 with 10 being extremely verbose
   logVerbosity: "2"