Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to manually specify charts to check #24

Open
gabegorelick opened this issue Nov 20, 2020 · 4 comments
Open

Ability to manually specify charts to check #24

gabegorelick opened this issue Nov 20, 2020 · 4 comments
Assignees
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: should Should be addressed shortly

Comments

@gabegorelick
Copy link

Is your feature request related to a problem? Please describe.

Nova does two things according to the README:

Nova scans your cluster for installed Helm charts, then cross-checks them against all known Helm repositories

I'd like to be able to use Nova for that second part (cross-checking Helm charts against their repositories to see if they're outdated and/or deprecated) without the first part (discovering the charts by scanning a cluster).

For example, scanning may fail if you didn't use helm install to install a chart (see #6). Or you may want to see if a chart is deprecated before you install it.

Describe the solution you'd like
Ability to manually specify the set of charts to check. Something like a --charts CLI option. Specifying this option would disable scanning for charts in the cluster and instead check the specified charts.

Describe alternatives you've considered
If you don't want scanning for charts, then perhaps there is a more purpose built tool that would make sense to use instead of Nova?

@sudermanjr sudermanjr added the priority: should Should be addressed shortly label Apr 7, 2021
@sudermanjr sudermanjr added this to the Q2 2021 milestone Apr 7, 2021
@sudermanjr sudermanjr removed this from the Q2 2021 milestone Oct 27, 2021
@sudermanjr sudermanjr added the pinned Prevents stalebot from removing label Oct 27, 2021
@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label May 16, 2023
@RohitKochhar
Copy link
Contributor

I'll tackle this. @rbren if you can assign this issue to me that would be perfecto

@RohitKochhar
Copy link
Contributor

I am almost thinking this would be better as a different sub-command something like nova precheck

There are a few reasons I am thinking this:

  1. nova find implies that we want to scan the cluster, so it seems a bit unintuitive to "ask" nova to find charts that aren't in the cluster, instead it would make more sense to "ask" nova to precheck a chart before install.
  2. For the amount of logic it would take to add this as a part of find, it would make more sense to just create a new subcommand. Having any sort of logic within find that would enable/disable scanning the cluster may overcomplicate things.

cc: @rbren @sudermanjr let me know what you guys think on this

@sudermanjr
Copy link
Member

I like the idea of making this a separate sub-command. I don't particularly love the name precheck. Either a name that encompasses the functionality better, or even a flag that modifies the behavior or find, such as --only-check=[]string might work.

@sudermanjr sudermanjr assigned RohitKochhar and unassigned rbren Sep 19, 2023
@RohitKochhar
Copy link
Contributor

RohitKochhar commented Sep 19, 2023

My concern with using it as a flag would be that the current logic flow of scanning the cluster would be bypassed, and that adding a conditional branch to see if that flag is handed to the find command would be equivalent to a separate command altogether (not sure if that makes sense, just don't want to mess around with the find logic if we aren't scanning the cluster)

I also am a bit curious about the use case here... so either the chart is installed not using helm and we want to check if it's outdated, or check if it's outdated before installing? I don't understand a scenario in which the chart is out of date before it's installed

@sudermanjr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: should Should be addressed shortly
Projects
Status: No status
Development

No branches or pull requests

4 participants