From 744e40a8886cfc6bb18eeaf1c32cea9a5e8b45ec Mon Sep 17 00:00:00 2001
From: Robert Brennan <accounts@rbren.io>
Date: Fri, 15 Jan 2021 13:55:59 -0500
Subject: [PATCH] remove details links (#473)

---
 pkg/dashboard/dashboard.go                   | 43 --------------------
 pkg/dashboard/templates/check-details.gohtml | 17 --------
 2 files changed, 60 deletions(-)
 delete mode 100644 pkg/dashboard/templates/check-details.gohtml
diff --git a/pkg/dashboard/dashboard.go b/pkg/dashboard/dashboard.go
index 64c7c302d..d52444550 100644
--- a/pkg/dashboard/dashboard.go
+++ b/pkg/dashboard/dashboard.go
@@ -29,7 +29,6 @@ import (
 	packr "github.com/gobuffalo/packr/v2"
 	"github.com/gorilla/mux"
 	"github.com/sirupsen/logrus"
-	"gitlab.com/golang-commonmark/markdown"
 )
 
 const (
@@ -45,8 +44,6 @@ const (
 	DashboardTemplateName = "dashboard.gohtml"
 	// FooterTemplateName contains the footer
 	FooterTemplateName = "footer.gohtml"
-	// CheckDetailsTemplateName is a page for rendering details about a given check
-	CheckDetailsTemplateName = "check-details.gohtml"
 )
 
 var (
@@ -71,14 +68,6 @@ func GetTemplateBox() *packr.Box {
 	return templateBox
 }
 
-// GetMarkdownBox returns a binary-friendly set of markdown files with error details
-func GetMarkdownBox() *packr.Box {
-	if markdownBox == (*packr.Box)(nil) {
-		markdownBox = packr.New("Markdown", "../../docs-md/checks")
-	}
-	return markdownBox
-}
-
 // templateData is passed to the dashboard HTML template
 type templateData struct {
 	BasePath          string
@@ -206,7 +195,6 @@ func GetRouter(c config.Configuration, auditPath string, port int, basePath stri
 		vars := mux.Vars(r)
 		category := vars["category"]
 		category = strings.Replace(category, ".md", "", -1)
-		DetailsHandler(w, r, category, basePath)
 	})
 
 	router.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
@@ -276,34 +264,3 @@ func JSONHandler(w http.ResponseWriter, r *http.Request, auditData *validator.Au
 	w.WriteHeader(http.StatusOK)
 	json.NewEncoder(w).Encode(auditData)
 }
-
-// DetailsHandler returns details for a given error type
-func DetailsHandler(w http.ResponseWriter, r *http.Request, category string, basePath string) {
-	box := GetMarkdownBox()
-	contents, err := box.Find(category + ".md")
-	if err != nil {
-		http.Error(w, "Error details not found for category "+category, http.StatusNotFound)
-		return
-	}
-	md := markdown.New(markdown.XHTMLOutput(true))
-	detailsHTML := "{{ define \"details\" }}" + md.RenderToString(contents) + "{{ end }}"
-
-	templateFileNames := []string{
-		HeadTemplateName,
-		NavbarTemplateName,
-		CheckDetailsTemplateName,
-		FooterTemplateName,
-	}
-	tmpl := template.New("check-details")
-	tmpl, err = parseTemplateFiles(tmpl, templateFileNames)
-	if err != nil {
-		logrus.Printf("Error getting template data %v", err)
-		http.Error(w, "Error getting template data", 500)
-		return
-	}
-	tmpl.Parse(detailsHTML)
-	data := templateData{
-		BasePath: basePath,
-	}
-	writeTemplate(tmpl, &data, w)
-}
diff --git a/pkg/dashboard/templates/check-details.gohtml b/pkg/dashboard/templates/check-details.gohtml
deleted file mode 100644
index 32c6ce1b8..000000000
--- a/pkg/dashboard/templates/check-details.gohtml
+++ /dev/null
@@ -1,17 +0,0 @@
-<!doctype html>
-<html>
-
-<head>
-  {{ template "head" . }}
-  <link rel="stylesheet" href="static/css/check-details.css">
-</head>
-
-<body>
-  {{ template "navbar" . }}
-  <div class="main-content">
-    <div class="card details">
-      {{ template "details" . }}
-    </div>
-  </div>
-</body>
-</html>
