-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk generation deadlock #35
Comments
Odd. I play with Lithium and I haven’t had this happen since I switched that line to the blocking version. |
Maybe I misattributed it, which other methods do you mean? |
There’s a .execute and a .executeBlocking method, and as far as I’m aware the blocking variant solves that issue. |
I think I've gotten to the bottom of the cause of this. Using modernfix's thread dump you can see that frozenlib's So I wrote a small mixin to just skip the disk generation (cancellable inject at head of Some notes:
|
Rip |
If anyone knows how to generate features similarly to structures (it saves, and generates per-chunk instead of generating all at once) that would be awesome and solve the issue completely |
@Treetrain1 maybe you could try doing this |
Fixed by simply removing this, and limiting features to a max radius of 15. |
This line seems to cause the chunk generation to deadlock. However, lithium is also in that stacktrace, so we are not sure whether it is really only caused by your mod.
FrozenLib/src/main/java/net/frozenblock/lib/worldgen/feature/api/features/FadingDiskTagFeature.java
Line 116 in 29e4e68
Crash report: https://mclo.gs/e5zFnhU
(First reported to CaffeineMC/lithium-fabric#493)
The text was updated successfully, but these errors were encountered: