-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IPCP independent of Ethernet #125
Comments
Hi @fdgonthier! I think that we probably have a terminology issue here. The "IPCP Task" is the single task that contains all the RINA implementation modules, including: the IPC Manager, the "normal" IPCP components, the shim IPCPs (right now only the WiFi one) and also a kind of "packet reception module" that gets the packets from the different drivers and dispatches them do shims. It should be renamed to something like "RINA Task" or something in the future. The other issue is that the module that gets events from the different drivers is embedded into the IPCP.c file, and it also does some work (processing Ethernet frames) that should be done within the shim WiFi. So, what @esmaxness and myself propose is:
What do you think? |
To put terminology aside, I am observing that the IPCP.c file has code which looks directly at Ethernet packet. This cannot be if we want to add a Bluetooth shim. That code should be moved in the ethernet (ie: wifi) shim. What your proposing to reach that goal is reasonable and probably what I would have organically ended up with. I do not engineer things ahead all that far. |
Since we want to use different kinds of shim (ie: Bluetooth), we need to make the IPCP independent of ethernet-based shims. Right now, the IPCP manipulates ethernet frames directly.
The text was updated successfully, but these errors were encountered: