Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basscss dependency #366

Open
mejiaj opened this issue Jul 21, 2022 · 1 comment
Open

Remove basscss dependency #366

mejiaj opened this issue Jul 21, 2022 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Jul 21, 2022

Basscss is deprecated and the github repo is archived. We should remove this dependency. Let's use USWDS tokens, utilities, and functions instead.

See main.scss

@import 'basscss-sass/scss/basscss';
@import 'basscss-sass/scss/responsive-margin';
@import 'basscss-sass/scss/responsive-padding';

For example, handling margins
https://github.com/basscss/basscss-sass/blob/master/scss/_responsive-margin.scss

Use USWDS tokens for spacing instead
https://designsystem.digital.gov/design-tokens/spacing-units/

@mejiaj mejiaj added the dependencies Pull requests that update a dependency file label Jul 21, 2022
@nick-mon1
Copy link
Contributor

This will be closed out when site is migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants