Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Append /<PLATFORM> to gameListFolder if defined in [<FRONTEND>] #68

Open
ASHGOLDOFFICIAL opened this issue Jun 12, 2024 · 4 comments

Comments

@ASHGOLDOFFICIAL
Copy link

To Reproduce

  • Define gameListFolder option in some [<FRONTEND>] section.
  • Run the scraper.
  • It places game list into gameListFolder not gameListFolder/<PLATFORM>

Expected behavior
It should behave the same as when defining gameListFolder in [main] section.

@Gemba
Copy link
Owner

Gemba commented Jun 24, 2024

Let me consider the implications, but right now I thinks it is a good enhancement.

Edit:
@ASHGOLDOFFICIAL On a second thought: What is the use-case / ease-of-use benefit for having this setting with the appended plaform folder in the frontend sections?

@ASHGOLDOFFICIAL
Copy link
Author

Use case: for example I use two different frontends (ES-DE on PC, and some other on my handheld emulator console). If that's the case, I need two different configs with different gameListFolder. It would be easy for me to have one config file that I can store on my GitHub. Something like that.

@Gemba
Copy link
Owner

Gemba commented Aug 7, 2024

Thanks for the input. Makes sense.

@Gemba
Copy link
Owner

Gemba commented Aug 10, 2024

As the change would only be valid for ESDE (and Emulationstation and Retrobat) frontend, does the environment variable ESDE_APPDATA_DIR fit your needs already? This environment variable is also evalutated by Skyscraper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants