Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accurate-as-of should have both links go to the accurate-as-of page #4299

Open
jrobbins opened this issue Aug 26, 2024 · 3 comments
Open

accurate-as-of should have both links go to the accurate-as-of page #4299

jrobbins opened this issue Aug 26, 2024 · 3 comments
Assignees

Comments

@jrobbins
Copy link
Collaborator

If a user gets an accurate-as-of reminder email, they might click the wrong link and go to the feature detail page. It would be better to eliminate that possible failure by making all links in the email message go to the accurate-as-of form. If the user wants to navigate to the feature detail page, they have ways to do that as a second step.

@jrobbins jrobbins self-assigned this Aug 26, 2024
@jrobbins
Copy link
Collaborator Author

Alternatively, we could display a dialog on the feature detail page whenever the feature needs an accurate-as-of update and the signed in user is a feature owner. That would allow us to keep the same email format that is consistent with other emails that we send out, and also guide the user to the accurate-as-of form if they are just visiting the site for some other reason.

I suppose that we could go further by adding the same dialog on all pages of the app, in addition to the feature detail page for that particular feature. It would need to be clear that the user is being asked to navigate to a different feature that they have responsibility for.

cc: @jstenback

@jstenback
Copy link
Collaborator

I like the idea of surfacing the need to verify feature data in more places!

@Varryme
Copy link

Varryme commented Aug 27, 2024

Your alternative scenario sounds like a solid approach! Here's a more detailed breakdown:

Alternative Scenario: Displaying a Dialog for Accurate-as-of Updates

Primary Scenario:

  • A feature owner receives an email notification to update the "accurate-as-of" date for a feature.

Alternative Scenario:

  • Display a dialog on the feature detail page whenever the feature needs an accurate-as-of update and the signed-in user is a feature owner.

Steps:

  1. User Visits Feature Detail Page:

    • User navigates to the feature detail page.
    • System checks if the feature needs an accurate-as-of update.
    • System verifies if the signed-in user is a feature owner.
  2. Dialog Display:

    • If both conditions are met, a dialog is displayed.
    • The dialog informs the user about the need for an accurate-as-of update.
    • The dialog provides a link to the accurate-as-of form.
  3. Consistent Email Format:

    • The email notification format remains consistent with other emails sent out.
    • The email guides the user to the accurate-as-of form if they are visiting the site for other reasons.

Extended Alternative Scenario:

  • Display Dialog on All Pages:
    • The same dialog is displayed on all pages of the app, not just the feature detail page.
    • The dialog clearly indicates that the user is being asked to navigate to a different feature they are responsible for.

Benefits:

  • Consistency: Maintains a consistent email format.
  • User Guidance: Guides users to the accurate-as-of form even if they visit the site for other reasons.
  • Visibility: Ensures that feature owners are reminded of their responsibilities regardless of which page they are on.

Considerations:

  • User Experience: Ensure the dialog is not intrusive and provides clear instructions.
  • Performance: Check the impact on app performance when displaying dialogs on all pages.
  • Security: Verify that only feature owners see the dialog.

Would you like to discuss any specific implementation details or potential challenges?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@jrobbins @jstenback @Varryme and others