Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o and O with org-evil-list-open-item-or-insert-{above/below} errors #19

Open
YangVincent opened this issue Jul 17, 2018 · 2 comments
Open

Comments

@YangVincent
Copy link

It seems like binding o and O to org-evil-list-open-item-above/below makes it work correctly. Normally, I'll go to a list and press o or O in normal mode, but I only observe a newline formed; no new bullet.

@YangVincent
Copy link
Author

It seems the same happens with headers too. I've put in a temporary workaround to simply use the internal function as such:

(evil-define-minor-mode-key 'normal 'org-evil-list-mode
  "<" 'org-evil-list-outdent-item-tree
  ">" 'org-evil-list-indent-item-tree
  "O" 'org-evil-list-open-item-above
  "o" 'org-evil-list-open-item-below)
;; Change o and O for org-evil so they function correctly in headings
(evil-define-minor-mode-key 'normal 'org-evil-heading-mode
  "<" 'org-evil-promote
  ">" 'org-evil-demote
  "O" 'org-evil-heading-open-sibling-above
  "o" 'org-evil-heading-open-sibling-below)


@GuiltyDolphin
Copy link
Owner

GuiltyDolphin commented Aug 6, 2018

@YangVincent Thanks for opening the issue (apologies for the late response)!

In version 0.4.0 I changed the open above/below bindings to require a prefix argument, do the bindings work fine for you if you try C-u o/C-u O?

The rationale was that the usual case when using o/O would be to open a new line for adding some additional text for the current/previous item/heading, but as o/O also make sense as 'open item/heading', I've kept them on the same key (but with a required prefix argument).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants