Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Householding: Add tests (and move to a rule?) #14

Open
curtismorales opened this issue Aug 4, 2015 · 3 comments
Open

Householding: Add tests (and move to a rule?) #14

curtismorales opened this issue Aug 4, 2015 · 3 comments

Comments

@curtismorales
Copy link
Collaborator

There should be a set of test for householding logic.

It also probably makes sense to move householding into a ruleset of its own and out of the ApplicationProcessor code.

@curtismorales
Copy link
Collaborator Author

@colinxfleming let me know if you have questions.

@colinxfleming
Copy link
Contributor

@curtismorales sounds good on tests. Specifically, we're looking for tests of the methods determine_household, calculate_household_size, and calculate_household_income right? Am I leaving anything out?

w/r/t moving the householding stuff (just those three methods above?) to a rule-style, it would probably make it way more testable for sure. I'll take a whack at it this week.

@curtismorales
Copy link
Collaborator Author

Yes to everything. Those three methods. And I think moving it to a rule-style is a good first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants