Skip to content
This repository has been archived by the owner on Mar 5, 2019. It is now read-only.

ui: introduce use of selectors for EntityList #168

Open
aspiers opened this issue Mar 29, 2017 · 0 comments
Open

ui: introduce use of selectors for EntityList #168

aspiers opened this issue Mar 29, 2017 · 0 comments

Comments

@aspiers
Copy link
Member

aspiers commented Mar 29, 2017

Description

The new EntityList component introduced by #167 has pretty terrible performance, but only half (roughly) of this is the slowness of fetching data from the API. The rest is mostly the cost of constructing the large entity list. We can do an initial optimisation on this by constructing the list using selectors, and then memoizing the results using the reselect selector library for Redux.

Comments, Questions and Considerations

#167 already ensures that the list of entities is only fetched from the API the first time it's needed, so we only need to optimise the rendering.

Plenty of nice HOWTOs are available for this, e.g.

Acceptance Criteria

This story can be considered done when the following acceptance tests
are satisfied:

Given a MUTI interface already showing a long entity list

When I switch away from the entity list and back to it again

Then it renders quickly without recalculating the HTML for the whole list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant