Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve efficiency of orderless matching #55

Open
HarrisonGrodin opened this issue Oct 20, 2018 · 0 comments
Open

Improve efficiency of orderless matching #55

HarrisonGrodin opened this issue Oct 20, 2018 · 0 comments
Labels
improvement Improvement to existing feature performance Related to code speed/performance

Comments

@HarrisonGrodin
Copy link
Owner

Currently, orderless matching simply tries all permutations of arguments:

https://github.com/HarrisonGrodin/Rewrite.jl/blob/03af1708d18f17efbc6e604b58c4d4943930607b/src/match.jl#L138-L146

This is clearly inefficient. We should be able to take advantage of the fact that OrderRule will sort all ground terms, thus requiring us only to attempt all possible variable positionings when matching.
@HarrisonGrodin HarrisonGrodin added the improvement Improvement to existing feature label Oct 20, 2018
@HarrisonGrodin HarrisonGrodin mentioned this issue Oct 20, 2018
Open
@HarrisonGrodin HarrisonGrodin added the performance Related to code speed/performance label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement to existing feature performance Related to code speed/performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HarrisonGrodin