-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Wall #261
Comments
Phew, good question. The company I currently work for uses My opinions on specific warnings are:
If you like, feel free to turn on warnings about 3–6 and others that I missed. |
Yeah, we can turn this off with
How about renaming the local
I think it can help remove clutter and discover unused dependencies. Note that you can of course temporarily use I agree with your points 4 to 6. I'm not sure when I'll get to implementing this. I've marked this issue "good first issue" in case someone's interested. |
No rush. 😄 Thanks for looking into this, Simon! |
I just noticed that this package doesn't use
-Wall
in the library or in the executables. When I enable-Wall
for the library, I get (with GHC-9.2.1):Of course, not all of these warnings are equally interesting. But some probably are.
My inclination would be to enable
-Wall
, try to address most of the warnings, and maybe disable certain warnings on a per-file basis, e.g. use-Wno-missing-signatures
insrc/Graphics/UI/Threepenny/Attributes.hs
.What do you think, @HeinrichApfelmus?
The text was updated successfully, but these errors were encountered: