Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any need to do CircleCI testing? #113

Open
guyharris opened this issue Mar 5, 2022 · 2 comments
Open

Is there any need to do CircleCI testing? #113

guyharris opened this issue Mar 5, 2022 · 2 comments

Comments

@guyharris
Copy link
Collaborator

We have a GitHub action that builds the drafts and updates the corresponding GitHub Pages; does the CircleCi testing provide any benefits not provided by the GitHub action?

Currently, that action is failing with

git -C /tmp/ghpages236 push -qf https://github.com/pcapng/pcapng gh-pages
Password for 'https://****************************************@github.com': make: *** [lib/ghpages.mk:123: ghpages] Hangup

Too long with no output (exceeded 10m0s): context deadline exceeded

which looks suspiciously as if the command

git -C $(GHPAGES_ROOT) push -qf https://$(GITHUB_PUSH_TOKEN)@github.com/$(GITHUB_REPO_FULL) gh-pages >/dev/null 2>&1

in lib/ghpages.mk is timing out because it's asking for a password and nobody supplies it with one. This may be due to the push token being bogus, or something such as that.

It appears that the GitHub Pages are getting updated by the GitHub action, so having CircleCI doesn't appear to be necessary, unless I'm missing something.

@alagoutte
Copy link
Contributor

Hi Guy,

I think it is only historic because there is no GitHub Actions on the origin of this repo...

@mcr
Copy link
Collaborator

mcr commented Aug 12, 2024

We can/should do whatever the MT Makefiles use, which I think is now Github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants