Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataset collection page for ui-v2 #671

Closed
adkinsrs opened this issue Mar 20, 2024 · 6 comments
Closed

Refactor dataset collection page for ui-v2 #671

adkinsrs opened this issue Mar 20, 2024 · 6 comments
Assignees
Labels
needs testing The task is complete but needs testing before it is closed
Milestone

Comments

@adkinsrs
Copy link
Member

This is normally @jorvis's domain, but I will take first crack at this.

@adkinsrs
Copy link
Member Author

Tentatively done with this. It is deployed to gear-devel for testing if anyone wants to try it out.

There are a lot of moving parts, so I certainly can imagine there are bugs or things I forgot to implement or design decisions that need to be reviewed

@adkinsrs adkinsrs added the needs testing The task is complete but needs testing before it is closed label Apr 23, 2024
@jorvis
Copy link
Member

jorvis commented Apr 23, 2024

Awesome! Does this included respecting the guser.is_admin and guser.is_curator settings yet? We need to elucidate out what those mean still.

@adkinsrs
Copy link
Member Author

adkinsrs commented Apr 23, 2024

Still need to do that. I was more or less referring to things that mirror functionality from v1 and the gene list manager along with various other previously discussed additions

@adkinsrs
Copy link
Member Author

adkinsrs commented Apr 23, 2024

New additions

  • Layout arranger is split into single and multi-gene layouts
  • Layout arranger now works for adjusting display width and height, as well as moving to different spots on a grid
  • Condensed table view of datasets
  • More explicit toggle to search all datasets or in the scope of the selected dataset collection
  • Toggle to make dataset downloadable. Dataset will also not be downloadable if the h5ad file is not present (per the database flag)
  • Various security-related fixes on what database pieces are returned to the client from the CGI calls.
  • Confirmation prompt to change dataset to public if a private dataset is added to a public collection.

Known things left to do

@adkinsrs
Copy link
Member Author

adkinsrs commented Jun 25, 2024

Also need to add the ability to change share IDs (permalinks) for dataset collections as well as individual datasets

This part is done

@adkinsrs
Copy link
Member Author

Last bullet point in the set has been converted into #871 so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing The task is complete but needs testing before it is closed
Projects
None yet
Development

No branches or pull requests

2 participants