Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single/Multi-gene curators - Do not pass filters or sort order params to API if not modified #923

Open
adkinsrs opened this issue Oct 23, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@adkinsrs
Copy link
Member

Related to the resolution of #919.

There are times where the user generates a display in the curator tools, and does not make any modifications to the filters or sort order parameters. Regardless if they were modified or not, they are passed into the API call with their current states. This becomes an issue if the dataset is reuploaded with new metadata, as data groups may change with the new iteration.

My suggestion for future-proofing some of these is to have a flag to detect if the filters or sort order have been modified or touched, and only pass them to the API call if they are modified. This will ensure that they will not break if the dataset itself is modified. This unfortunately will not be backwards compatible with existing curations as the properties have already been saved to database.

@adkinsrs adkinsrs added the enhancement New feature or request label Oct 23, 2024
@adkinsrs adkinsrs self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant