Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config .ini file needs rework to properly support port value #348

Open
bklaas opened this issue Dec 28, 2022 · 1 comment
Open

Config .ini file needs rework to properly support port value #348

bklaas opened this issue Dec 28, 2022 · 1 comment

Comments

@bklaas
Copy link

bklaas commented Dec 28, 2022

default host is statspilot.gsalibs.org/api, which is not a host it's a url stub. this makes the port value show up in the wrong spot in the cobbled together URI, e.g. statspilot.gsalibs.org/api:443/rpc/update_presence. That will fail

I'll make the change to fix the issue and make a PR after testing the fix

@bklaas
Copy link
Author

bklaas commented Dec 28, 2022

FYI @meenubhooshanan this will allow the port param to stay in the .go code for creating URIs, as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant