Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaboration of MongoDB tables - Database structure. #1019

Closed
xdxxxdx opened this issue Nov 29, 2023 · 5 comments
Closed

Elaboration of MongoDB tables - Database structure. #1019

xdxxxdx opened this issue Nov 29, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@xdxxxdx
Copy link

xdxxxdx commented Nov 29, 2023

LDES Server - Snapshot 2.4.0

image
In MongoDB, 14 tables are created once launched the LDES Server.
Some of them remain empty.
e.g:

  1. fragmentation_allocation
  2. ldesfragment
  3. ldesmember

It might be a good idea to elaborate on the usage of each table in the doc, for the future open-source community and remove the redundant ones.

Thanks.

@xdxxxdx xdxxxdx added the enhancement New feature or request label Nov 29, 2023
@xdxxxdx xdxxxdx changed the title Elaboration of mongodb tables Elaboration of MongoDB tables - Database structure. Nov 29, 2023
@rorlic
Copy link
Contributor

rorlic commented Nov 30, 2023

Sorry, I believe it is a very bad idea to elaborate on the document collections: the last thing we want is for people to start depending on these. We need to reserve the freedom to change these as we see fit in order to improve performance or for whatever other reason.

Your concern on the empty collections is however legit: these are remains of a previous server & storage architecture and should ideally be removed.

@xdxxxdx
Copy link
Author

xdxxxdx commented Nov 30, 2023

Hello @rorlic, I agree with your idea. From my perspective, we need to have it documented somewhere before the end of project.
Thanks

@Yalz
Copy link
Contributor

Yalz commented Dec 2, 2023

@rorlic i think it's due to Mongock migrations.. Needs to be looked at.

But I follow you on documenting these tables. We keep track of our DB changes via Mongock which gives an explanation.

If we start writing static code, we are doomed to have documentation errors

@Yalz
Copy link
Contributor

Yalz commented Jan 2, 2024

TO DO: delete redundant tables after clearing in mongock steps.

@Tomvbe Tomvbe self-assigned this Mar 21, 2024
@Tomvbe
Copy link
Contributor

Tomvbe commented Mar 28, 2024

The application (develop branch) currently only creates the tables that are used. I know that above was an issue in the past but I was not able to reproduce it anymore with the latest server and mongo. Whether or not we should document the usage of the other database collections can be part of #346. Since we may migrate to PostgreSQL in the near future, it may be best to wait with this as well.

@Tomvbe Tomvbe closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants