Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List refresh control does not follow orientation #868

Open
flochtililoch opened this issue May 22, 2024 · 0 comments
Open

List refresh control does not follow orientation #868

flochtililoch opened this issue May 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@flochtililoch
Copy link
Collaborator

When the list is rendered horizontally, the refresh control is still rendered vertically, causing the list content to be scrollable in both directions. We should make it so that the refresh control follows the list's orientation.
See a quick example hacked together using the examples:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-22.at.13.03.57.mp4

and git patch to quickly recreate the example:
list.patch

The underlying RefreshControl from react native does not seem to support orientation, and it's using native bindings to render the control based on platform. We might want to explore:

  • looks for 3rd party implementation or create our custom refresh control for horizontal list
  • try to use rotation transform style to rotate the refresh control itself, or the whole list and their items (instead of using the horizontal prop)
  • disable the ability to set refresh control on horizontal lists.
@flochtililoch flochtililoch added the bug Something isn't working label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant