[Feature request]: Interface to atomic properties #115
Labels
code maintenance
Issue/PR for refactors, code clean up, etc.
enhancement
New feature or request
good first issue
Good for newcomers
Feature/behavior summary
Instead of hardcoded numbers littered around the codebase without units or traceability, we should provide a standardized interface for reference atomic/chemical property values by introducing maintained dependencies like
mendeleev
andperiodictable
.As examples, MACE and M3gnet implementations have brought in dictionaries that provide utility, but are literally hardcoded mappings like
matsciml.datasets.utils.atomic_number_map
.Request attributes
Related issues
No response
Solution description
The core idea would be to provide a consistent, "vectorized" or broadcast-able interface to retrieve reference atomic and chemical properties, such as ionization energies and just atomic symbol-number mappings. I don't know if we need a class based implementation, but at the very least, functions that look like this:
We can choose to abstract things out more, but some things might get a bit more tricky (e.g. fully stripped ions, etc.)
Additional notes
No response
The text was updated successfully, but these errors were encountered: