Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Normalization keys mismatch fails silently #75

Open
laserkelvin opened this issue Dec 8, 2023 · 0 comments · May be fixed by #76
Open

[Bug]: Normalization keys mismatch fails silently #75

laserkelvin opened this issue Dec 8, 2023 · 0 comments · May be fixed by #76
Assignees
Labels
bug Something isn't working training Issues related to model training ux User experience, quality of life changes

Comments

@laserkelvin
Copy link
Collaborator

Expected behavior

When normalization parameters are passed, if there are no keys matched up we should throw an error or warning message to notify the user that nothing is being normalized.

Actual behavior

Currently, there is no "validation" persay of normalization keys passed, and so if they aren't matched with any of the targets, nothing happens.

Steps to reproduce the problem

Pass normalization kwargs, and have none of the keys match available targets.

Specifications

matsciml as of 46dd595

@laserkelvin laserkelvin added the bug Something isn't working label Dec 8, 2023
@laserkelvin laserkelvin self-assigned this Dec 8, 2023
@laserkelvin laserkelvin added training Issues related to model training ux User experience, quality of life changes labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working training Issues related to model training ux User experience, quality of life changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant